From 269717eb1c61ad3895ca31069432fdeba6ea6805 Mon Sep 17 00:00:00 2001 From: Patrice Ferlet Date: Sun, 8 Mar 2026 22:52:24 +0100 Subject: [PATCH] fix(err): No port with depends_on As #182 were not clear, the `depends_on` from a compose file needs, at this time, to check the port of the dependent service. If the port is not declared (ports or with label), we need to "fail", not to "warn. Fixes #182 --- internal/generator/deployment.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/generator/deployment.go b/internal/generator/deployment.go index 51259d6..3d0616e 100644 --- a/internal/generator/deployment.go +++ b/internal/generator/deployment.go @@ -268,13 +268,12 @@ func (d *Deployment) DependsOn(to *Deployment, servicename string) error { for _, container := range to.Spec.Template.Spec.Containers { commands := []string{} if len(container.Ports) == 0 { - logger.Warn("No ports found for service ", + logger.Fatal("No ports found for service ", servicename, ". You should declare a port in the service or use "+ labels.LabelPorts+ " label.", ) - os.Exit(1) } for _, port := range container.Ports { command := fmt.Sprintf("until nc -z %s %d; do\n sleep 1;\ndone", to.Name, port.ContainerPort)