Katenary/katenary
2
0
Fork 3
Code Issues 13 Pull Requests 2 Actions Packages Projects 4 Releases 18 Wiki Activity

feat(quality): fixes some bad patterns
All checks were successful
Go-Tests / tests (pull_request) Successful in 2m8s
Details
Go-Tests / sonar (pull_request) Successful in 40s
Details

Browse Source
This commit is contained in:
Patrice Ferlet
2026-03-16 21:37:50 +01:00
parent 0e133ae6db
commit 985418ae51
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/generator/deployment.go
View File

@@ -19,6 +19,8 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
) )
const shCommand = "/bin/sh"
var _ Yaml = (*Deployment)(nil) var _ Yaml = (*Deployment)(nil)
type mountPathConfig struct { type mountPathConfig struct {
@@ -294,7 +296,7 @@ func (d *Deployment) dependsOnLegacy(to *Deployment, servicename string) error {
commands = append(commands, command) commands = append(commands, command)
} }
command := []string{"/bin/sh", "-c", strings.Join(commands, "\n")} command := []string{shCommand, "-c", strings.Join(commands, "\n")}
d.Spec.Template.Spec.InitContainers = append(d.Spec.Template.Spec.InitContainers, corev1.Container{ d.Spec.Template.Spec.InitContainers = append(d.Spec.Template.Spec.InitContainers, corev1.Container{
Name: "wait-for-" + to.service.Name, Name: "wait-for-" + to.service.Name,
Image: "busybox:latest", Image: "busybox:latest",
@@ -318,7 +320,7 @@ until wget -q -O- --header="Authorization: Bearer $(cat /var/run/secrets/kuberne
sleep 2 sleep 2
done` done`
command := []string{"/bin/sh", "-c", fmt.Sprintf(script, to.Name)} command := []string{shCommand, "-c", fmt.Sprintf(script, to.Name)}
d.Spec.Template.Spec.InitContainers = append(d.Spec.Template.Spec.InitContainers, corev1.Container{ d.Spec.Template.Spec.InitContainers = append(d.Spec.Template.Spec.InitContainers, corev1.Container{
Name: "wait-for-" + to.service.Name, Name: "wait-for-" + to.service.Name,
Image: "busybox:latest", Image: "busybox:latest",
@@ -652,7 +654,6 @@ func (d *Deployment) Yaml() ([]byte, error) {
func (d *Deployment) SetServiceAccountName() { func (d *Deployment) SetServiceAccountName() {
if d.needsServiceAccount { if d.needsServiceAccount {
d.Spec.Template.Spec.ServiceAccountName = utils.TplName(d.service.Name, d.chart.Name, "dependency") d.Spec.Template.Spec.ServiceAccountName = utils.TplName(d.service.Name, d.chart.Name, "dependency")
} else {
} }
} }