Katenary/katenary
2
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

fix(deployment): Missed the command from compose file #135

Merged
metal3d merged 1 commits from issue-133 into develop 2025-07-12 22:10:22 +00:00
Conversation 0 Commits 1 Files Changed 2 +37
metal3d commented 2025-07-12 22:08:50 +00:00
Owner
Copy Link

This pull request enhances the handling and testing of container commands in the deployment generator. The changes include adding support for specifying commands in service configurations and introducing a new test to validate this functionality.

Enhancements to container command handling:

  • generator/deployment.go: Updated the AddContainer method to include the Command field from the service configuration when creating containers.

Testing improvements:

  • generator/deployment_test.go: Added a new test, TestCheckCommand, to verify that commands specified in the service configuration are correctly included in the generated deployment YAML. The test ensures the command structure matches expectations and validates the number and content of command elements.Fixes #133
This pull request enhances the handling and testing of container commands in the deployment generator. The changes include adding support for specifying commands in service configurations and introducing a new test to validate this functionality. Enhancements to container command handling: * [`generator/deployment.go`](diffhunk://#diff-d980d24f8bd990a1d2918af6dd78c2fff5bf931de30e8a81d1c5f800e78e1402R139): Updated the `AddContainer` method to include the `Command` field from the `service` configuration when creating containers. Testing improvements: * [`generator/deployment_test.go`](diffhunk://#diff-918af45463145df72129335ed9302dfd5fbebf1d99a79c40930051ff694291c8R498-R533): Added a new test, `TestCheckCommand`, to verify that commands specified in the service configuration are correctly included in the generated deployment YAML. The test ensures the command structure matches expectations and validates the number and content of command elements.Fixes #133
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
partially fixed
Some fixes are already made in current release / developpement
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
metal3d
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Katenary/katenary#135
No description provided.
Delete Branch "issue-133"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?