Katenary/katenary
2
0
Fork 3
Code Issues 13 Pull Requests 2 Actions Packages Projects 4 Releases 18 Wiki Activity

Wrong syntax with TCP healthcheck #30

New Issue
Closed
opened 2022-07-20 15:36:54 +00:00 by adrian-salas · 1 comment
adrian-salas commented 2022-07-20 15:36:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Hello,

After using the following label:
katenary.io/healthcheck: tcp://localhost:3306

The generated output is the following:

livenessProbe:
  tcp:
    port: 3306
            ...

However the syntax is: tcpSocket (https://kubernetes.io/fr/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#d%C3%A9finir-une-tcp-liveness-probe)

Hello, After using the following label: `katenary.io/healthcheck: tcp://localhost:3306` The generated output is the following: ``` livenessProbe: tcp: port: 3306 ... ``` However the syntax is: `tcpSocket` (https://kubernetes.io/fr/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#d%C3%A9finir-une-tcp-liveness-probe)
fkukus commented 2022-07-21 06:27:17 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Hello,
I reproduce the issue and confirm the fix is correct.
Thanks!

Hello, I reproduce the issue and confirm the fix is correct. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 go
Pull requests that update go code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 partially fixed
Some fixes are already made in current release / developpement
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
metal3d (Patrice Ferlet)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Katenary/katenary#30