Katenary/katenary
2
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Develop #119

Merged
metal3d merged 3 commits from develop into master 2025-06-15 13:14:11 +00:00
Conversation 1 Commits 3 Files Changed 2 +67 -48
metal3d commented 2025-06-15 12:50:37 +00:00
Owner
Copy Link
No description provided.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-06-15 12:51:19 +00:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Author
Owner
Copy Link

Pull Request Overview

This PR updates documentation spacing in labels.md and enhances the Makefile with a new doc target and Go version bump.

  • Added blank lines for better readability before each label section in labels.md.
  • Bumped GOVERSION to 1.24, added a doc target and updated .PHONY in the Makefile.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
doc/docs/labels.md Inserted blank lines before each ### katenary.v3/... heading to improve readability.
Makefile Updated GOVERSION to 1.24, added doc target, and updated .PHONY to include doc.
## Pull Request Overview This PR updates documentation spacing in `labels.md` and enhances the Makefile with a new `doc` target and Go version bump. - Added blank lines for better readability before each label section in `labels.md`. - Bumped `GOVERSION` to 1.24, added a `doc` target and updated `.PHONY` in the Makefile. ### Reviewed Changes Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments. | File | Description | | --------------------- | -------------------------------------------------------- | | doc/docs/labels.md | Inserted blank lines before each `### katenary.v3/...` heading to improve readability. | | Makefile | Updated `GOVERSION` to 1.24, added `doc` target, and updated `.PHONY` to include `doc`. |
Makefile
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-06-15 12:51:19 +00:00
Author
Owner
Copy Link

Add __label_doc to the .PHONY list to ensure the helper target is always run and not mistaken for a filename.

Add `__label_doc` to the `.PHONY` list to ensure the helper target is always run and not mistaken for a filename.
Makefile
copilot-pull-request-reviewer[bot] (Migrated from github.com) commented 2025-06-15 12:51:19 +00:00
Author
Owner
Copy Link

The doc target currently only ensures gomarkdoc is installed but does not invoke it to actually generate documentation. Consider adding a command such as gomarkdoc -o doc/docs/labels.md ./doc/docs (or the appropriate invocation) after the install step.

The `doc` target currently only ensures gomarkdoc is installed but does not invoke it to actually generate documentation. Consider adding a command such as `gomarkdoc -o doc/docs/labels.md ./doc/docs` (or the appropriate invocation) after the install step.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
partially fixed
Some fixes are already made in current release / developpement
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
metal3d
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Katenary/katenary#119
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?