Katenary/katenary
2
0
Fork 2
Code Issues 13 Pull Requests 1 Actions Packages Projects 4 Releases 18 Wiki Activity

Adding svc-optional #181

Open
joshuacox wants to merge 1 commits from joshuacox/katenary:svc-optional into master
pull from: joshuacox/katenary:svc-optional
merge into: Katenary:master
Conversation 2 Commits 1 Files Changed 6 +33 -1
joshuacox commented 2025-12-03 02:52:33 +00:00
First-time contributor
Copy Link

fixes #180

scratching my own itch and making a svc optional

fixes #180 scratching my own itch and making a svc optional
joshuacox added 1 commit 2025-12-03 02:52:37 +00:00
Adding svc-optional
Some checks failed
Go-Tests / tests (pull_request) Successful in 5m21s
Details
Go-Tests / sonar (pull_request) Failing after 37s
Details
3a1c170140
metal3d commented 2025-12-07 10:09:29 +00:00
Owner
Copy Link

Thanks a lot.
Is there any unit test that we can add?

Thanks a lot. Is there any unit test that we can add?
metal3d added the
enhancement
 label 2025-12-07 10:09:37 +00:00
joshuacox commented 2025-12-10 16:39:59 +00:00
Author
First-time contributor
Copy Link

let me take a stab at something like that. Also, I notice the resulting values.yaml does not have a enabled line for the service. I'll look around for that too. Any pointers on how I should do those two things? I'll start looking around now, any advice is appreciated.

let me take a stab at something like that. Also, I notice the resulting values.yaml does not have a enabled line for the service. I'll look around for that too. Any pointers on how I should do those two things? I'll start looking around now, any advice is appreciated.
Some checks failed
Go-Tests / tests (pull_request) Successful in 5m21s
Details
Go-Tests / sonar (pull_request) Failing after 37s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u svc-optional:joshuacox-svc-optional
git checkout joshuacox-svc-optional
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
partially fixed
Some fixes are already made in current release / developpement
question
Further information is requested
wontfix
This will not be worked on
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
metal3d
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Katenary/katenary#181
No description provided.
Delete Branch "joshuacox/katenary:svc-optional"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?