Katenary/katenary
2
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Some fixes on "same-pod" and volumes + add some tests #82

Merged
metal3d merged 20 commits from develop into master 2024-11-25 22:17:56 +00:00
Conversation 1 Commits 20 Files Changed 36 +1259 -518
metal3d commented 2024-11-21 10:19:05 +00:00
Owner
Copy Link
No description provided.
codecov[bot] commented 2024-11-22 14:14:35 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

Codecov Report

Attention: Patch coverage is 73.33333% with 36 lines in your changes missing coverage. Please review.

Project coverage is 76.67%. Comparing base (af8dabb) to head (fc33524).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
generator/deployment.go 72.60% 14 Missing and 6 partials ⚠️
generator/katenaryfile/main.go 46.15% 5 Missing and 2 partials ⚠️
generator/chart.go 70.00% 2 Missing and 1 partial ⚠️
generator/labels/labelStructs/exchangeVolume.go 57.14% 2 Missing and 1 partial ⚠️
generator/labels/labelStructs/ingress.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   73.82%   76.67%   +2.85%     
==========================================
  Files          34       35       +1     
  Lines        3117     3173      +56     
==========================================
+ Hits         2301     2433     +132     
+ Misses        667      582      -85     
- Partials      149      158       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

## [Codecov](https://app.codecov.io/gh/metal3d/katenary/pull/82?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) Report Attention: Patch coverage is `73.33333%` with `36 lines` in your changes missing coverage. Please review. > Project coverage is 76.67%. Comparing base [(`af8dabb`)](https://app.codecov.io/gh/metal3d/katenary/commit/af8dabba8555175c3c5b2155b478e663e65f325d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) to head [(`fc33524`)](https://app.codecov.io/gh/metal3d/katenary/commit/fc335247f8fe8055e577a47c21571679aa145598?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet). > Report is 27 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/metal3d/katenary/pull/82?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) | Patch % | Lines | |---|---|---| | [generator/deployment.go](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&filepath=generator%2Fdeployment.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet#diff-Z2VuZXJhdG9yL2RlcGxveW1lbnQuZ28=) | 72.60% | [14 Missing and 6 partials :warning: ](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) | | [generator/katenaryfile/main.go](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&filepath=generator%2Fkatenaryfile%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet#diff-Z2VuZXJhdG9yL2thdGVuYXJ5ZmlsZS9tYWluLmdv) | 46.15% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) | | [generator/chart.go](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&filepath=generator%2Fchart.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet#diff-Z2VuZXJhdG9yL2NoYXJ0Lmdv) | 70.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) | | [generator/labels/labelStructs/exchangeVolume.go](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&filepath=generator%2Flabels%2FlabelStructs%2FexchangeVolume.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet#diff-Z2VuZXJhdG9yL2xhYmVscy9sYWJlbFN0cnVjdHMvZXhjaGFuZ2VWb2x1bWUuZ28=) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) | | [generator/labels/labelStructs/ingress.go](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&filepath=generator%2Flabels%2FlabelStructs%2Fingress.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet#diff-Z2VuZXJhdG9yL2xhYmVscy9sYWJlbFN0cnVjdHMvaW5ncmVzcy5nbw==) | 40.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/metal3d/katenary/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #82 +/- ## ========================================== + Coverage 73.82% 76.67% +2.85% ========================================== Files 34 35 +1 Lines 3117 3173 +56 ========================================== + Hits 2301 2433 +132 + Misses 667 582 -85 - Partials 149 158 +9 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/metal3d/katenary/pull/82?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrice+Ferlet).
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
partially fixed
Some fixes are already made in current release / developpement
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
metal3d
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Katenary/katenary#82
No description provided.
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?